Mitigated Serial Monitor resource exhaustion #2491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e sends a lot of data Fixes arduino#2233
cmaglie
added
Component: IDE user interface
| len = getDocument().getLength(); | ||
| if (len > maxChars) { | ||
| int n = len - maxChars; | ||
| System.out.println("trimDocument: remove " + n + " chars"); |
|
Oh, opps, yeah, I missed that print before committing the code. |
|
It looks like if I unckeck autoscrolling, it stops working. Right after re-enabling it, it says (with that removed println) it has removed all the accumulated extra chars. Something like |
|
Yup, work remains to be done for turning off autoscroll. I wrote a more detailed explanation here: |
|
If you or anyone else reading works on this, please understand that you absolutely must not trim the document while autoscroll is turned off. Doing so ruins the user experience. But you can discard incoming data (before it's added to the document), hopefully after some reasonable threshold that won't be hit for slower data rates and only brief disable of autoscroll. |
Before this patch every byte received from Serial invokes a String allocation, not really efficient. Moreover a InputStreamReader is chained on the serial InputStream to correctly convert bytes into UTF-8 characters.
When the "autoscroll" checkbox is deselected the buffer may continue to grow up to twice of the maximum size. This is a compromise to ensure a better user experience and, at the same time, reduce the chance to lose data and get "holes" in the serial stream. See arduino#2491
|
I've updated the pull request:
|
per1234
added
Component: IDE Serial monitor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2233
Tested on a Dual-core 1.8Ghz Linux 64bit system with 4GB of RAM: the Serial Monitor performance are dramatically improved.
/cc @PaulStoffregen @willie68 @xxxajk @ffissore